(CONT-19) Update config_defaults gems

- Added Rubocop gems missing from original commit
- Add lower bounds to all gems
- Remove `puppet-lint` as it is brought in by `voxpupuli-puppet-lint-plugins`
- Remove `specinfra` as it is brought in by `serverspec`
- Move `serverspec` to system_tests
- Remove `ed25519` and `bcrypt_pbkf` as they are brought in by `net-ssh`
- Remove `rspec-puppet` as it is brought in by `puppetlabs_spec_helper`
- Pin `facterdb` to 1.18 and up as this is the version which adds Ub22.04
- Remove code previously used to retrieve ruby version

Author: david22swan

config_defaults.yml

@@ -557,32 +557,39 @@ Gemfile:
   required:
     ':development':
       - gem: 'json'
+        version: '~> 2.0'
       - gem: 'voxpupuli-puppet-lint-plugins'
-        version: '>= 3.0.0'
+        version: '~> 3.0'
       - gem: 'facterdb'
-        version: '< 2.0.0'
+        version: '~> 1.18'
       - gem: 'metadata-json-lint'
-        version: '< 4.0.0'
-      - gem: 'puppet-lint'
-        version: '< 3.0.0'
+        version:
+        - '>= 2.0.2'
+        - '< 4.0.0'
       - gem: 'puppetlabs_spec_helper'
-        version: '< 4.0.0'
-      - gem: 'rspec-puppet'
-        version: '< 3.0.0'
+        version:
+        - '>= 3.0.0'
+        - '< 5.0.0'
       - gem: 'rspec-puppet-facts'
-        version: '< 3.0.0'
+        version: '~> 2.0'
       - gem: 'codecov'
+        version: '~> 0.2'
       - gem: 'dependency_checker'
+        version: '~> 0.2'
       - gem: 'parallel_tests'
+        version: '~> 3.4'
       - gem: 'pry'
-      - gem: 'serverspec'
+        version: '~> 0.10'
       - gem: 'simplecov-console'
-      - gem: 'specinfra'
+        version: '~> 0.5'
       - gem: 'puppet-debugger'
-      - gem: 'ed25519'
-        platforms: ruby
-      - gem: 'bcrypt_pbkdf'
-        platforms: ruby
+        version: '~> 1.0'
+      - gem: 'rubocop'
+        version: '= 1.6.1'
+      - gem: 'rubocop-performance'
+        version: '= 1.9.1'
+      - gem: 'rubocop-rspec'
+        version: '= 2.0.1'
       - gem: 'rb-readline'
         version: '= 0.5.5'
         platforms:
@@ -593,6 +600,8 @@ Gemfile:
       - gem: 'puppet_litmus'
         version: '< 1.0.0'
         platforms: ruby
+      - gem: 'serverspec'
+        version: '~> 2.41'
 .gitlab-ci.yml:
   defaults:
     cache:

moduleroot/Gemfile.erb

@@ -71,9 +71,6 @@ def location_for(place_or_version, fake_version = nil)
   end
 end
 
-ruby_version_segments = Gem::Version.new(RUBY_VERSION.dup).segments
-minor_version = ruby_version_segments[0..1].join('.')
-
 <%
   groups = {}
   (@configs['required'].keys + ((@configs['optional'] || {}).keys)).uniq.each do |key|