Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (c7b8ac4) to head (6494399).
Report is 32 commits behind head on master.

@@            Coverage Diff             @@
##           master    #2981      +/-   ##
==========================================
+ Coverage   68.30%   68.48%   +0.18%     
==========================================
  Files         330      334       +4     
  Lines       42108    43212    +1104     
==========================================
+ Hits        28761    29593     +832     
- Misses      11766    11963     +197     
- Partials     1581     1656      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Feel free to check this in but this does not fix 2974 as in principle we still have test isolation issues that can surface is that correct?

You're right, this PR is mainly a response to changes in the converter, which add additional network calls when encountering a required_provider section, which this test doesn't need.

Going to add my thoughts on #2974 over there - had a few thoughts.

Another source of confusion and problem in this test case is

Configure the OpenStack Provider
provider "simple-provider" {
  user_name   = "admin"
  tenant_name = "admin"
  password    = "pwd"
  auth_url    = "http://myauthurl:5000/v3"
  region      = "RegionOne"
}

Should be probably this:

provider "simple"

As it thinks provider-simple is very different from the one needed for simple_ resources.

It would be great to understand what this fixes, and possibly take this as an improvement but pulumi/pulumi-converter-terraform#319 remains a problem as of this morning:

anton@anton-mbp-m3> pulumi plugin ls                                                                                                     ~/code/pulumi-terraform-bridge
NAME       KIND       VERSION  SIZE   INSTALLED      LAST USED
terraform  converter  1.1.0    40 MB  8 seconds ago  8 seconds ago

The test is not isolated as it auto-installs the converter at latest version.

Am I perhaps running this wrong?

Hm 🤔 - this test should now be exactly as isolated as TestConvertViaPulumiCLI. I thought this meant the only way it would install the converter was by going through the converter install in Makefile but it appears I was wrong.

I'm not sure that it is a significant problem anymore though - the test will not attempt to install the latest converter, and instead abide by the converter version specified in Make. So if tests are run via Make, which is what CI uses, this should be OK.