Incorrect history Actions type #407
Assignees
Labels
priority: medium
This PR should be reviewed after all high priority PRs.
status: in progress
This issue is being worked on.
type: fix
This PR contains fixes to existing features.
Comments
parfeon
added
status: in progress
parfeon
added a commit
that referenced
this issue
Oct 30, 2024
Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message. Closes #407 refactor(types): remove indexed signature for publish Remove redundant indexed signature from publish message parameters type definition. Closes #413 refactor(types): add serializable objects to `Payload` type Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods. Closes #412 refactor(types): aggregate generated types definitions Aggregate multiple types definitions into single type definition type with proper type names and namespaces. Closes #405 #409 #410 refactor(types): add missing Subscribe Event Engine types Add Subscribe Event Engine and Event Listener types to the bundled types definition file. Closes #377
parfeon
added a commit
that referenced
this issue
Oct 31, 2024
fix(types): fix `Actions` type definition Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message. Closes #407 refactor(types): remove indexed signature for publish Remove redundant indexed signature from publish message parameters type definition. Closes #413 refactor(types): add serializable objects to `Payload` type Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods. Closes #412 refactor(types): aggregate generated types definitions Aggregate multiple types definitions into single type definition type with proper type names and namespaces. Closes #405 #409 #410 refactor(types): add missing Subscribe Event Engine types Add Subscribe Event Engine and Event Listener types to the bundled types definition file. Closes #377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current typing for the history
Actionsinterface is wrong. It defines the action value as an object when it is actually an array of objects.javascript/src/core/types/api/history.ts
Lines 134 to 144 in 0beda2c
The text was updated successfully, but these errors were encountered: