fix: "onKeyPress" prop of TextInput

aleclarson · aleclarson · commit d09a4d933b64 · 2019-02-16T13:31:46.000-05:00
The replacement text in "shouldChangeTextInRange:replacementText:" may be a mutable string, so we need to copy it to prevent changes to the "_predictedText" internal property.
diff --git a/Libraries/Text/TextInput/RCTBaseTextInputView.m b/Libraries/Text/TextInput/RCTBaseTextInputView.m
@@ -279,7 +279,7 @@ - (BOOL)textInputShouldChangeTextInRange:(NSRange)range replacementText:(NSStrin
   if (_predictedText) {
     _predictedText = [_predictedText stringByReplacingCharactersInRange:range withString:text];
   } else {
-    _predictedText = text;
+    _predictedText = [text copy];
   }
 
   if (_onTextInput) {

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,7 @@ - (BOOL)textInputShouldChangeTextInRange:(NSRange)range replacementText:(NSStrin`
`279`	`279`	`if (_predictedText) {`
`280`	`280`	`_predictedText = [_predictedText stringByReplacingCharactersInRange:range withString:text];`
`281`	`281`	`} else {`
`282`		`- _predictedText = text;`
	`282`	`+ _predictedText = [text copy];`
`283`	`283`	`}`
`284`	`284`
`285`	`285`	`if (_onTextInput) {`