Skip to content

updates typescript to v5.4.2 #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

uncvrd
Copy link
Contributor

@uncvrd uncvrd commented Mar 12, 2024

Hi there! This should close #401 and #405 (please refer to my breakdown in #401 for more context)

I discovered a similar issue with Tanstack Query and the resolution was updating Typescript to the latest stable version v5.4.2.

TanStack/query#6318

After updating and building this package, typesafety was restored with moduleResolution bundler. I think we got pretty lucky with the timing here since this update from TS was just released!

For parity, I went ahead and matched all TS versions in all packages, I hope that's okay. Other than that...this was quite an easy fix after staring at it for a second!

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 6eebec7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
supabase-cache-helpers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 7:59am

Copy link

vercel bot commented Mar 12, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @psteinroe on Vercel.

@psteinroe first needs to authorize it.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (d9d8cbf) to head (6eebec7).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   96.99%   97.02%   +0.03%     
==========================================
  Files         149      149              
  Lines        2194     2217      +23     
  Branches      523      541      +18     
==========================================
+ Hits         2128     2151      +23     
  Misses         62       62              
  Partials        4        4              
Flag Coverage Δ
postgrest-core 97.02% <ø> (+0.03%) ⬆️
postgrest-react-query 97.02% <ø> (+0.03%) ⬆️
postgrest-swr 97.02% <ø> (+0.03%) ⬆️
storage-core 97.02% <ø> (+0.03%) ⬆️
storage-react-query 97.02% <ø> (+0.03%) ⬆️
storage-swr 97.02% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psteinroe
Copy link
Owner

@uncvrd awesome, thanks! Can you add a changeset using pnpm changeset to trigger a new release?

@uncvrd
Copy link
Contributor Author

uncvrd commented Mar 12, 2024

@psteinroe do I just run "pnpm changeset" from the root of the repo?

Never done it before..I can do that in the morning though

@psteinroe
Copy link
Owner

Yes! No worries, I can also do it later. good night! 😴

@psteinroe psteinroe merged commit 45cb83d into psteinroe:main Mar 12, 2024
@uncvrd
Copy link
Contributor Author

uncvrd commented Mar 12, 2024

@psteinroe thanks so much! Just confirming this has fixed the issue on my end 🙏

@uncvrd uncvrd deleted the update-typescript-v542 branch March 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use library when using "moduleResolution: 'bundler'" in tsconfig.json?
2 participants