-
-
Notifications
You must be signed in to change notification settings - Fork 41
updates typescript to v5.4.2 #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Someone is attempting to deploy a commit to a Personal Account owned by @psteinroe on Vercel. @psteinroe first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 96.99% 97.02% +0.03%
==========================================
Files 149 149
Lines 2194 2217 +23
Branches 523 541 +18
==========================================
+ Hits 2128 2151 +23
Misses 62 62
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@uncvrd awesome, thanks! Can you add a changeset using pnpm changeset to trigger a new release? |
@psteinroe do I just run "pnpm changeset" from the root of the repo? Never done it before..I can do that in the morning though |
Yes! No worries, I can also do it later. good night! 😴 |
@psteinroe thanks so much! Just confirming this has fixed the issue on my end 🙏 |
Hi there! This should close #401 and #405 (please refer to my breakdown in #401 for more context)
I discovered a similar issue with Tanstack Query and the resolution was updating Typescript to the latest stable version v5.4.2.
TanStack/query#6318
After updating and building this package, typesafety was restored with moduleResolution bundler. I think we got pretty lucky with the timing here since this update from TS was just released!
For parity, I went ahead and matched all TS versions in all packages, I hope that's okay. Other than that...this was quite an easy fix after staring at it for a second!