Invoke-Build Task Improvements #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Incorporate new StageFiles features Fix: Prereqs as If conditionals Fix: Dependencies variable doesn't work because Invoke-Build tasks compile dependencies ahead of time. Throw an error instead with proper override guidance
JustinGrote
force-pushed
the
fix/InvokeBuild
branch
from
5f95576 to
5bbbd4f
Compare
|
Thanks @JustinGrote! |
JustinGrote
commented
Mar 14, 2021
| @@ -113,7 +115,7 @@ $genMarkdownPreReqs = { | |||
| } | |||
|
|
|||
| # Synopsis: Generates PlatyPS markdown files from module help | |||
| task GenerateMarkdown StageFiles, { | |||
| task GenerateMarkdown -if ($genMarkdownPreReqs) StageFiles,{ | |||
There was a problem hiding this comment.
@devblackops minor bug here I think, this should be (. $genMarkdownPrereqs), my bad, may want to do a quick patch commit since you already merged the PR.
There was a problem hiding this comment.
Good catch. I'll fix and publish v0.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invoke-Build Task Fixes
Fix: StageFiles and Pester brought in line with PSake equivalents
Fix: Prereqs as If conditionals
Fix: Dependencies variable doesn't work because Invoke-Build tasks compile dependencies ahead of time. Throw an error instead with proper override guidance