add rdzv_backend parameter to DDPJobDefinition #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelClifford
force-pushed
the
rdzv_backend
branch
2 times, most recently
from
4f57836 to
c5d9899
Compare
|
@MichaelClifford Can you rebase on main? |
MichaelClifford
force-pushed
the
rdzv_backend
branch
from
c5d9899 to
4808aca
Compare
|
@anishasthana rebased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to define the rdzv_backend to be used when creating a DDPJobDefinition.
This change is required because currently, the backend is hard coded to "static" in torchx dist.py. Howver, depending on whether or not we are using the Ray Scheduler or the MCAD scheduler, the required backend needs to change as well.
This PR will be paired with an upcoming change to torchx/OCP that accounts for the different backends submitted here.