Update notebooks and docs with updated Cluster Configuration args #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ygnas
requested review from
Bobbins228 and
sutaakar
and removed request for
dimakis and
franciscojavierarceo
Contributor
|
/lgtm |
Contributor
|
@Ygnas Can you please also patch the replacing commands in https://github.com/project-codeflare/codeflare-sdk/blob/main/.github/workflows/guided_notebook_tests.yaml ? Edit: Seems there is no patching needed. |
Contributor
|
/lgtm |
Bobbins228
suggested changes
Aug 22, 2024
Contributor
Bobbins228
left a comment
Bobbins228
left a comment
There was a problem hiding this comment.
Small nit then I'm happy with lgtming this
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-7686
What changes have been made
Update notebooks and docs with updated Cluster Configuration args
Verification steps
Checks