Added support for checking version of the codeflare-sdk package #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPostOffice
reviewed
Jun 28, 2024
KPostOffice
reviewed
Jun 28, 2024
- changed the comment - changed default value to v0.0.0
KPostOffice
approved these changes
Jul 9, 2024
openshift-ci
bot
added
lgtm
ChristianZaccaria
approved these changes
Jul 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 342d54c
into
project-codeflare:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Add support for version : #504
What changes have been made
Added support to check the version of the codeflare-sdk package.
Using
print(codeflare_sdk.__version__)gives the version number of the version that is installed.Verification steps
Verified the usage as follows:
Checks