-
Notifications
You must be signed in to change notification settings - Fork 53
Fix ODH notebooks sync workflow #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ODH notebooks sync workflow #574
Conversation
f716610
to
8633ab3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix Abhijeet! :)
I think we shouldn't update the SDK version on any of the python3.8 files as it's no longer supported with the newer version of the SDK. Perhaps removing the python version from line 47 will suffice.
8633ab3
to
924030b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@abhijeet-dhumal Looks like the PR generating is not updating Codeflare-sdk verison file in ubi9-python-3.9/Pipfile Srihari1192/notebooks#14 |
@Srihari1192 you're right, great catch! - We are expecting 18 file changes in this case then. |
924030b
to
ae7d076
Compare
Thank you so much @Srihari1192 for pointing this out ! Now it is working.. |
d74a88a
to
99d1e1c
Compare
Now it is working.. Please check : https://github.com/Srihari1192/notebooks/pull/19/files
looks good to me |
1a2e84b
to
a68906b
Compare
a68906b
to
75f8bf8
Compare
I have added some more conditional statements to consider 3.10 usecase.. It is now working seamlessly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ChristianZaccaria, Srihari1192 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
RHOAIENG-9027
What changes have been made
Added fix to change directory logic and to cleanup pipfile's-pipenv's cache.
Verification steps
A test run in fork results in the following automated PR changes :
Successful sample test build
Generated PR - https://github.com/Srihari1192/notebooks/pull/20/files ✔️
Checks