Skip to content

Update Token Authentication for TestMnistJobSubmit before step get_cluster #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Srihari1192
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/RHOAIENG-7032
While running in CI test TestMnistJobSubmit failing due to authentication and default kube config not in default location

What changes have been made

updated Token Authentication step before calling get_cluster function for TestMnistJobSubmit

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Srihari1192 Srihari1192 changed the title update Token Authentication for TestMnistJobSubmit before step get_cluster Update Token Authentication for TestMnistJobSubmit before step get_cluster Jun 13, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhijeet-dhumal, sutaakar
Once this PR has been reviewed and has the lgtm label, please assign kpostoffice for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Srihari1192 Srihari1192 merged commit 3864bcf into project-codeflare:main Jun 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants