-
Notifications
You must be signed in to change notification settings - Fork 53
Updating training script in basic_interactive notebook #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating training script in basic_interactive notebook #545
Conversation
0f6b8eb
to
9f339d6
Compare
d47295b
to
4e7a49e
Compare
6126cc3
to
431d308
Compare
95addca
to
a074625
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to test with the latest-py39-cu118
image. It worked like a charm.
Happy to lgtm once the images are set back.
Awesome work Fiona 🚀
demo-notebooks/guided-demos/notebook-ex-outputs/2_basic_interactive.ipynb
Outdated
Show resolved
Hide resolved
a074625
to
cf2e140
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
This PR just needs a rebase and it should pass the e2e test |
cf2e140
to
b07f9aa
Compare
b07f9aa
to
5c80181
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1e80e62
into
project-codeflare:main
Issue link
RHOAIENG-6475
What changes have been made
When running GPU utilising workloads using the basic_interactive demo notebook I encountered a lot of errors while running the training script provided in the notebook. As it was added more than a year ago and may be out of date I have updated the notebook to use ray train using these examples: Text classification, Hugging Face Transformers + Ray Train
I have also updated the hf_interactive notebook which was using the same training script.
Verification steps
Managed
Checks