-
Notifications
You must be signed in to change notification settings - Fork 53
Add GPU to ClusterConfiguration #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU to ClusterConfiguration #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicated demo notebooks in the preview nbs and expected output folders also need to be updated with the same changes
9a68108
to
4cdb19b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
demo-notebooks/guided-demos/notebook-ex-outputs/0_basic_ray.ipynb
Outdated
Show resolved
Hide resolved
Can we group the gpus together like this for all notebooks:
Also the cluster_job_client demos would need to be updated like this too. Thanks |
1da820c
to
49d8857
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9da541d
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-6666
What changes have been made
Add GPU to ClusterConfiguration
Verification steps
Checks