Skip to content

Add GPU to ClusterConfiguration #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

oksanabaza
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/RHOAIENG-6666

What changes have been made

Add GPU to ClusterConfiguration

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicated demo notebooks in the preview nbs and expected output folders also need to be updated with the same changes

@oksanabaza oksanabaza force-pushed the jupyter-nb branch 2 times, most recently from 9a68108 to 4cdb19b Compare May 7, 2024 09:18
@oksanabaza oksanabaza requested a review from Bobbins228 May 14, 2024 08:45
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

@Bobbins228
Copy link
Contributor

Bobbins228 commented May 14, 2024

Can we group the gpus together like this for all notebooks:

head_gpus=1 # For GPU enabled workloads set the head_gpus and num_gpus
num_gpus=1

Also the cluster_job_client demos would need to be updated like this too. Thanks

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2024
@oksanabaza oksanabaza force-pushed the jupyter-nb branch 2 times, most recently from 1da820c to 49d8857 Compare May 27, 2024 10:15
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2024
@Fiona-Waters
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@KPostOffice
Copy link
Collaborator

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Bobbins228,KPostOffice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9da541d into project-codeflare:main May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants