print correct dashboard link #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atinsood
reviewed
Nov 3, 2022
| @@ -175,6 +175,10 @@ def _get_app_wrappers(filter:List[AppWrapperStatus], namespace='default') -> Lis | |||
|
|
|||
| def _map_to_ray_cluster(cluster) -> RayCluster: | |||
| cluster_model = cluster.model | |||
|
|
|||
| with oc.project(cluster.namespace()), oc.timeout(10*60): | |||
There was a problem hiding this comment.
@MichaelClifford can we just call the cluster.dashboard_uri() method here rather than trying to get the route again. I think we are already doing the same logic in both teh places.
There was a problem hiding this comment.
@atinsood My original goal was to use the cluster.dashboard_uri() here. But the "cluster" object that gets passed to _map_to_ray_cluster is the raycluster API object from openshift not the Cluster class we've defined in our SDK. So, right now we can't reuse that method here, unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.