Sanitize UserInfo.UID before using as label value (#368)

dgrove-oss · web-flow · commit f4f215281327 · 2025-09-13T20:53:20.000-04:00
Fixes #367
diff --git a/internal/webhook/appwrapper_webhook.go b/internal/webhook/appwrapper_webhook.go
@@ -92,7 +92,8 @@ func (w *appWrapperWebhook) Default(ctx context.Context, obj runtime.Object) err
 	}
 	userInfo := request.UserInfo
 	username := utils.SanitizeLabel(userInfo.Username)
-	aw.Labels = utilmaps.MergeKeepFirst(map[string]string{AppWrapperUsernameLabel: username, AppWrapperUserIDLabel: userInfo.UID}, aw.Labels)
+	userUID := utils.SanitizeLabel(userInfo.UID)
+	aw.Labels = utilmaps.MergeKeepFirst(map[string]string{AppWrapperUsernameLabel: username, AppWrapperUserIDLabel: userUID}, aw.Labels)
 
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,8 @@ func (w *appWrapperWebhook) Default(ctx context.Context, obj runtime.Object) err`
`92`	`92`	`}`
`93`	`93`	`userInfo := request.UserInfo`
`94`	`94`	`username := utils.SanitizeLabel(userInfo.Username)`
`95`		`- aw.Labels = utilmaps.MergeKeepFirst(map[string]string{AppWrapperUsernameLabel: username, AppWrapperUserIDLabel: userInfo.UID}, aw.Labels)`
	`95`	`+ userUID := utils.SanitizeLabel(userInfo.UID)`
	`96`	`+ aw.Labels = utilmaps.MergeKeepFirst(map[string]string{AppWrapperUsernameLabel: username, AppWrapperUserIDLabel: userUID}, aw.Labels)`
`96`	`97`
`97`	`98`	`return nil`
`98`	`99`	`}`