Skip to content

Migrate ant based serial library to Gradle #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

madhav2348
Copy link

@madhav2348 madhav2348 commented May 16, 2025

Description

Migrated the serial library from Ant-based build.xml to Gradle build.gradle.kts

Resolve Issue

#1099

Changes

Migrate Ant-based build.xml with build.gradle.kts for java/libraries/serial

Checklist

Build succeeds using Gradle
serial no longer relies on Ant

  • build.gradle.kts creates build folder in library/serial by default contains serial.jar, even if define source outDir path explicitly
  • If I deleted build.xml, the Branch Builds (Legacy) GitHub action failed as build.xml was not found

Although I was able to run the project and only commit the main Gradle file changes

Let me know if further adjustments are needed!

@Stefterv
Copy link
Collaborator

Hi @madhav2348 Thank you for your contribution and your effort!

Rather than directly translating the Ant build file to Gradle in a one-to-one translation we are looking to have something more Gradle native. Please take a look at how the other gradle files have been organised, especially with regard to importing the results of other modules.

@madhav2348
Copy link
Author

Thankyou for your feedback , I'll make sure to implement those approach

@madhav2348 madhav2348 closed this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants