Skip to content

Final Emulator Improvements for Apple M1 Silicon and cmdline-tools check #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

rupeshkumar22
Copy link
Contributor

@rupeshkumar22 rupeshkumar22 commented Aug 7, 2022

Fixes #708 and #696

For now, if we select the existing SDK with sdk/tools(and without cmdline-tools), it continues with sdk/tools as cmdline-tools and later causes the error as SDK tools are deprecated and are not compatible with Java 17 that we are using. Based on the discussions, This PR enforces to use the command line tools only as SDK tools are deprecated.

Also, I have applied the changes to download arm64-v8a for M1 Mac. If you can test this on Mac, it would be helpful @codeanticode @ranaaditya

An outcome of Google Summer of Code 2022
Author - Rupesh Kumar @rupeshkumar22
Mentor - Aditya Rana @ranaaditya
Project Lead(Processing For Android) - Andrés Colubri @codeanticode

@codeanticode
Copy link
Contributor

@rupeshkumar22 thanks for this PR! Couple of quick questions/comments:

  • The TARGET_SDK_ARM constant was introduced at some point because seemed that the latest arm images were not up to date with the latest SDK level, but this was years ago and I wonder if we can just use TARGET_SDK everywhere
  • Have you tested the smartwatch emulator? I haven't, but will give it a try while reviewing this PR.

@codeanticode codeanticode merged commit 0c6b2e1 into processing:master Aug 8, 2022
@rupeshkumar22
Copy link
Contributor Author

@codeanticode I think now arm images are up to date these days and We can use TARGET_SDK_ARM after setting it to a higher API level. Currently, it is set to 24 here.
I have not checked the smartwatch emulator, I will check that. Also, looking into the image installation issue on m1 that you have shared through email. Thanks for heading this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download arm64-v8a system images on Apple Silicon macs
2 participants