Skip to content

Update AndroidBuild.java for AAB Jar Signing(V1 Signature) #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Update AndroidBuild.java for AAB Jar Signing(V1 Signature) #677

merged 1 commit into from
Apr 10, 2022

Conversation

rupeshkumar22
Copy link
Contributor

Hi @codeanticode @ranaaditya
I found that just Jar signing (V1 signature Scheme) would be sufficient to build bundles that would be uploadable on Play Console. Not sure as I don't have access to the play console But I tried comparing the signing information of the Jar Signed Bundle generated from this PR and the signed bundle generated from Android Studio. I found that both the bundles are signed with the same signing algorithm.

Android Mode Generated Bundle's Signing Information

C:\Users\xyz> keytool -printcert -jarfile C:\Users\xyz\Documents\Processing\sketch_220405a\buildBundle.220405.1115\sketch_220405a_release_signed_v1.aab
Signer #1:
Signature:
Certificate fingerprints:
         SHA1: 24:E4:***
         SHA256: 05:30:***
Signature algorithm name: SHA256withRSA
Subject Public Key Algorithm: 2048-bit RSA key
Version: 3
Android Studio Generated Bundle's Signing Information

Signer #1:
Signature:
Certificate fingerprints:
         SHA1: DA:08:***
         SHA256: 2D:A9:***
Signature algorithm name: SHA256withRSA
Subject Public Key Algorithm: 2048-bit RSA key
Version: 3

I thought of signing aab with bundletool but it's not included in SDK and the size of bundletool-all.jar is around 26 mb where as AndroidMode itself is around 13 MB. Later found that Jar Signing(V1 signature scheme) would be sufficient.

Can you confirm if the generated signed bundle is uploadable on Play Console? @codeanticode

Thanks,
Rupesh

@codeanticode
Copy link
Contributor

@rupesh-kumar-lpu Awesome, thanks for looking into this. I will review as soon as I can.

@rupeshkumar22
Copy link
Contributor Author

rupeshkumar22 commented Apr 6, 2022

I will wait for your review @codeanticode , Furthermore, I faced an issue while using existing V2Signing on APK it showed an error while exporting APK So I commented that code in the PR and just used V1(Jar Signing) on APK and AAB. I will try to look into it but if it does not fits well there is an alternative of using APKSigner.bat which is also present in build tools folder of SDK along with zipalign binary and APKSigner.bat can be executed similar to that of zipalign with a runtime execute task or process builder task. Let me know if it seems a better option, I can create another PR for that @codeanticode

@codeanticode codeanticode merged commit 26a35cf into processing:master Apr 10, 2022
@codeanticode
Copy link
Contributor

Ok appears that uploading the aab with V1 signing is enough! (but API level needs to be updated to 30, I will look into that next)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants