don't check for sdk inside the constructor of AndroidMode #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check again happens inside the contructor of AndroidEditor class which also ensures that editor will never be null. Signed-off-by: Umair Khan <[email protected]>
|
Might fix #156 What was happening in my case was "bad day" dialog box would come and after closing that, sdk selection download box would come. |
Signed-off-by: Umair Khan <[email protected]>
codeanticode
added a commit
that referenced
this pull request
Oct 22, 2015
don't check for sdk inside the constructor of AndroidMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check again happens inside the contructor of AndroidEditor class
which also ensures that editor will never be null.
Signed-off-by: Umair Khan [email protected]