Skip to content

Download API level 22 SDK by default #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2015
Merged

Download API level 22 SDK by default #135

merged 2 commits into from
Aug 20, 2015

Conversation

omerjerk
Copy link
Contributor

Signed-off-by: Umair Khan [email protected]

@benfry
Copy link
Contributor

benfry commented Aug 18, 2015

This should be 15 or 16... Why would we do 22 as the default?

@omerjerk
Copy link
Contributor Author

22 as the default doesn't mean that it limits the user to have at least Android 5.1.1 (API 22) on his/her phone. The minimum API level is set by minSdkVersion attribute inside the manifest. Higher target API level gives the user access to all the new API in case he/she wants to use them.

P.S. I just realized we set minSdkVersion same as targetSdkVersion which will be 22 in this case. I can send another patch to hardcode it as 15.

@benfry
Copy link
Contributor

benfry commented Aug 19, 2015

Yup, that's what I'm saying. The constant should probably be renamed if it's going to have separate/new meanings.

codeanticode added a commit that referenced this pull request Aug 20, 2015
Download API level 22 SDK by default
@codeanticode codeanticode merged commit d223c9d into processing:master Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants