Skip to content

Fetch Process continues even after SDK updater window is closed #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DeerajTheepshi opened this issue Mar 21, 2019 · 4 comments
Closed

Comments

@DeerajTheepshi
Copy link
Contributor

How to Recreate issue :

  1. Switch to android mode
  2. Open android->SdkUpdater
  3. Close it before the updates are fetched. (This happens in case of slow internet connectivity)
  4. The console, still shows a fetch process running.

Priority: Minimum. This shouldn't be causing any other problems.

Ready to Work on it? : Yes

@SyamSundarKirubakaran
Copy link
Contributor

SyamSundarKirubakaran commented Mar 23, 2019

I think that is the way it is intended to be.! In Android Studio, if SDK is being fetched over the network the user is blocked from performing any other activities on the IDE .i.e., Blocking state. But I think what Processing does is good.! Making it fetch in the background while having the instance of the older SDK for current builds.

My Personal opinion would be having a Cancel button to terminate the fetch instead of removing it from background.

@codeanticode @kfrajer Thoughts.!?

@mario-vimal
Copy link

mario-vimal commented Feb 26, 2020

I noticed this issue while closing the SDK updater. If no one is working on this, I would like to take this up. Is it fine if a Message Dialog is shown stating that a background process is running? Also, stopping the fetch thread on confirmation? @codeanticode @DeerajTheepshi @kfrajer

@ranaaditya
Copy link
Member

Hi @rupeshkumar22 , is this issue resolved or we are yet to implement it ?

Seems like we have already discussed this in sdk updater and emulator bringup issue catchup already.

Thanks,
rana !

@rupeshkumar22
Copy link
Contributor

Hi @ranaaditya , this is yet to implement, Yes this is the same issue that we discussed. The major issue is that on startup of SDKUpdater UI, It crashes because the library (sdklib) used in SDKUpdater uses old java dependencies which have been removed in java 17, that we started using. I updated the sdklib and related methods in SDKUpdater and the issue was not removed. Seems like the recent versions of the library(sdklib) also use old imports of java. But it seems we can probably find a fix. #666

Thanks,
Rupesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants