[FEAT] Explicit error message when using too old TypeScript versions #2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript projects integrating `bpmn-visualization` but using an unsupported TypeScript version now get an explicit error message instead of a list of type errors. Related changes - The documentation provide general guidelines to contributors about the supported TypeScript versions and how changed them. - As types are now generated in several steps, Rollup is no more in charge of generating the types. Rollup was previously generating the files several times (each time it generated a bundle so 3*2=6 times), so this was a lost of time. - Rename the tsconfig.json file used to prepare the npm package. It now has a clearer name. - Do not generate package-lock.json in the typescript-support tests and remove it from git. The version of bpmn-visualization should be updated in this file after each release. We don't want to do it, so avoid to generate the lock file
tbouffard
added
enhancement
5 tasks
|
♻️ PR Preview 1135a3e has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 1135a3e has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
…e generated when building bundles
csouchet
suggested changes
Oct 3, 2022
Co-authored-by: Souchet Céline <[email protected]>
csouchet
approved these changes
Oct 3, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript projects integrating
bpmn-visualizationbut using an unsupported TypeScript version now get an explicit error message instead of a list of type errors.For instance, when using TypeScript Version 4.4.4
Related changes
closes #2246
Possible tests for reviewers
To get the error message
test/typescript-support/package.jsonand use TS 4.3 for instancenpm installnpm testshould fail and display the expected error message