Skip to content

Commit 0a94420

Browse files
joshblackJosep Martins
andauthored
fix(Select): move selected from <option> to defaultValue on <select> (#2511)
* fix(Select): move selected from <option> to defaultValue on <select> * chore: add changeset Co-authored-by: Josep Martins <[email protected]>
1 parent e74e6df commit 0a94420

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react': patch
3+
---
4+
5+
Remove selected from <option> and add defaultValue for <select> when placeholder is provided

src/Select.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,11 @@ const Select = React.forwardRef<HTMLSelectElement, SelectProps>(
8787
disabled={disabled}
8888
aria-invalid={validationStatus === 'error' ? 'true' : 'false'}
8989
data-hasplaceholder={Boolean(placeholder)}
90+
defaultValue={placeholder ?? undefined}
9091
{...rest}
9192
>
9293
{placeholder && (
93-
<option value="" disabled={required} selected hidden={required}>
94+
<option value="" disabled={required} hidden={required}>
9495
{placeholder}
9596
</option>
9697
)}

0 commit comments

Comments
 (0)