Skip to content

Update enforce-css-module-identifier-casing.js #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

francinelucca
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Apr 22, 2025

🦋 Changeset detected

Latest commit: 83b4a47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@francinelucca francinelucca marked this pull request as ready for review April 23, 2025 02:30
@Copilot Copilot AI review requested due to automatic review settings April 23, 2025 02:30
@francinelucca francinelucca requested a review from a team as a code owner April 23, 2025 02:30
@francinelucca francinelucca requested a review from TylerJDev April 23, 2025 02:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the enforce-css-module-identifier-casing rule by adding an additional null check to improve robustness against undefined references. The key changes include:

  • Adding optional chaining to verify that the reference exists before accessing its properties.
  • Updating the changeset documentation to reflect this improvement.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/rules/enforce-css-module-identifier-casing.js Added optional chaining (null check) to avoid runtime errors
.changeset/mean-shrimps-train.md Updated changeset note to document the null check update

@francinelucca francinelucca merged commit 1b70cf1 into main Apr 23, 2025
8 checks passed
@francinelucca francinelucca deleted the francinelucca-patch-1 branch April 23, 2025 13:44
@primer-css primer-css mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants