Add new rule no-deprecated-experimental-components
#325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 481a89c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@francinelucca - I changed the rule name to |
francinelucca
requested changes
Apr 8, 2025
Co-authored-by: Marie Lucca <[email protected]>
Co-authored-by: Marie Lucca <[email protected]>
hectahertz
requested changes
Apr 9, 2025
Co-authored-by: Hector Garcia <[email protected]>
francinelucca
requested changes
Apr 9, 2025
| meta: { | ||
| type: 'problem', | ||
| docs: { | ||
| description: 'Use deprecated components from the `@primer/react/deprecated` entrypoint', |
There was a problem hiding this comment.
oop, can we fix this description? 🙏
There was a problem hiding this comment.
Yup! Should now be "Use a stable component from the @primer/react/deprecated entrypoint, or check the docs for alternatives".
TylerJDev
commented
Apr 9, 2025
francinelucca
approved these changes
Apr 9, 2025
hectahertz
approved these changes
Apr 10, 2025
TylerJDev
commented
Apr 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/primer/issues/4786
Introduces a new ESLint rule to discourage the use of deprecated
experimentalcomponents. This will mainly be utilized for SelectPanelV2, but is generalized to potentially include otherexperimentalcomponents.