-
Notifications
You must be signed in to change notification settings - Fork 10
Add no-deprecated-props
rule
#156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e7d2216 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's totally fine to make this one rule and keep adding to it. We can always break it up later if we need to.
3e7f99a
to
9ff3d65
Compare
9ff3d65
to
221802b
Compare
Based on our team discussion about deprecating props that are related to accessibility changes, seems like introducing a complementary eslint rule to enforce the new API (not using the deprecated prop) is a practise worth trying.
This rule has a generic name but it only handles ActionList.Group title prop (for now). I am not sure if I should make this as generic as its name suggests i.e. adding a deprecated props and suggested fix lists so that we can enhance later or should I rename this to be only specific to ActionList.Group title prop. I am not sure which way would be better. I would love your opinions.
TODO: Ad docs and related config after getting initial feedback.
Old API
New API