Skip to content

no-system-props: skip html elements #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Mar 7, 2024

When using skipImportCheck, we need to skip html elements because they can definitely have attributes that look like system props.

For example: <img width="200px" />

@siddharthkp siddharthkp requested a review from a team as a code owner March 7, 2024 16:18
@siddharthkp siddharthkp requested a review from mperrotti March 7, 2024 16:18
Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: 0dbb7a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp self-assigned this Mar 7, 2024
@siddharthkp siddharthkp merged commit 523e169 into main Mar 8, 2024
@siddharthkp siddharthkp deleted the no-system-props/skip-html-elements branch March 8, 2024 14:07
@primer-css primer-css mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants