Update from upstream repo facebook/create-react-app@next #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.
This reverts commit bab2c29. I meant to apply it to `next` instead.
Support for .mjs files added in #3239 did not account for npm libraries which ship native mjs files alongside js files. This accounts for this by ensuring .js files resolve before their accompanying .mjs file. Note that this is not an ideal end state since selecting a .mjs over a .js extension should be the result of whether `import` was used instead of `require()` in a node environment with native ESM support (currently via `--experimental-modules`). Instead, this change just *always* selects a .js extension before the .mjs extension if it exists. This unbreaks support for using GraphQL (relay, apollo, etc) within create-react-app projects.
Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
* add react-testing-library documentation/examples * make react-testing-library a heading * fix typo
* Use file name whitelist to prevent RCE
Use a whitelist to validate user-provided file names. This doesn't cover
the entire range of valid filenames but should cover almost all of them
in practice. Allows letters, numbers, periods, dashes, and underscores.
Opting to use a whitelist instead of a blacklist because getting this
wrong leaves us vulnerable to a RCE attack.
* Allow alphabet characters from all languages
Updated the whitelist to /^[\p{L}0-9/.\-_]+$/u, which matches
alphanumeric characters, periods, dashes, and underscores. Unicode
property support is stage 4 so I've inlined the transpiled version.
* Only use file name whitelist on Windows
* Log error message if file name does not pass whitelist
This fixes the functionality of this dependency for Node 10 and above. Refs: webpack/webpack-dev-server#1451 Refs: nodejs/node#21665
* Update jest version * Update babel-jest version * Use testURL: http://localhost in jest configs. * Update to jest version 23.5 This version of jest includes a fix for jsdom/jsdom#2304 * "testURL": "http://localhost" is default with jest v23.5
* Only install react-scripts in CI mode * Link locally * Re-enable all output tests * 💄 Polish webpack output * Test sass support message * Add more tests, but disabled * Format missing default export error * Format aliased import * Why was node-sass required? Odd * Format webpack rejection error * Re-enable unknown package test * Format file not found error and catch module scope plugin error * Re-disable case sensitive paths * Intercept and format case sensitive path errors * Test out of scope message formatting * Run behavior on macOS * Run behavior on Node 8 and 10, only Node 8 for macOS * Add some debugging * Update matcher * Only check stderr * Remove old snapshot * More debug * Remove debug * Add new debug * Disable test on linux * Add comment for future
* Strip flow syntax before any other transform Plugins run before presets so we can't use the flow preset * Add informative comment
* Updates to README to reflect Workbox usage. * Update README.md * Update README.md
* Test flow types are stripped before class properties are transformed * Do not search multiple levels deep * Revert "Do not search multiple levels deep" This reverts commit 5b5324d. * Add missing file for test script to boot * Make sure src and node modules are ignored * Fix error * derp * fix test * Drop unneeded check
Replace `src/setupTests.js` with `src/setupProxy.js`.
* Format SVG React snapshots as <svg> tag with props * Keep output simpler
* Document importing SVGs as React components * Update README.md
* Adds the PnP plugin for Webpack to find dependencies when working under PnP * Adds configuration for jest * Adds an e2e test for when using PnP * Avoids cra from crashing at the engine check * Avoids cra from crashing when initializing react-scripts * Makes the ownPath portable * Fixes linting * Bumps to [email protected], removes symlinks: false * Adds a --use-pnp option * Pin version
* Polyfill for IE9 support * Turn off performance option in webpack
* Disable react/no-deprecated rule * Changed wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The upstream repository
facebook/create-react-app@nexthas some new changes that aren't in this fork. So, here they are, ready to be merged! 🎉If this pull request can be merged without conflict, you can publish your software with these new changes. Otherwise, fix any merge conflicts by clicking the
Resolve Conflictsbutton.If you like Backstroke, consider donating to help us pay for infrastructure here. Backstroke is a completely open source project that's free to use, but we survive on sponsorships and donations. Thanks for your support! Help out Backstroke.
Created by Backstroke (I'm a bot!)