Review comments

czentgr · czentgr · commit 76a6e2f676f2 · 2024-12-02T15:40:26.000-05:00
diff --git a/presto-native-execution/presto_cpp/main/common/ConfigReader.cpp b/presto-native-execution/presto_cpp/main/common/ConfigReader.cpp
@@ -32,7 +32,7 @@ void extractValueIfEnvironmentVariable(std::string& value) {
     if (envVal != nullptr) {
       if (strlen(envVal) == 0) {
         LOG(WARNING) << fmt::format(
-            "Config environment variable {} was empty.", envName);
+            "Config environment variable {} is empty.", envName);
       }
       value = std::string(envVal);
     }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ void extractValueIfEnvironmentVariable(std::string& value) {`
`32`	`32`	`if (envVal != nullptr) {`
`33`	`33`	`if (strlen(envVal) == 0) {`
`34`	`34`	`LOG(WARNING) << fmt::format(`
`35`		`- "Config environment variable {} was empty.", envName);`
	`35`	`+ "Config environment variable {} is empty.", envName);`
`36`	`36`	`}`
`37`	`37`	`value = std::string(envVal);`
`38`	`38`	`}`