Skip to content

fix: remove show tables column retrieval index based #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Feb 4, 2022

Improves the metadata retrieval of existing tables, the position based approach is bad and fails on elasticsearch 7.16.X.

Fixes: #80

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #81 (b9f60ac) into master (cad716e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head b9f60ac differs from pull request most recent head 524cb28. Consider uploading reports for the commit 524cb28 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   94.39%   94.41%   +0.02%     
==========================================
  Files          15       15              
  Lines         963      967       +4     
==========================================
+ Hits          909      913       +4     
  Misses         54       54              
Flag Coverage Δ
python 94.41% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
es/exceptions.py 100.00% <ø> (ø)
es/elastic/api.py 87.00% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad716e...524cb28. Read the comment docs.

@dpgaspar dpgaspar merged commit ba15a2e into master Feb 7, 2022
@dpgaspar dpgaspar deleted the fix/new-es-get-tables branch February 7, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic Search 7.16.1 Superset 1.4 missing Tables for default schema
2 participants