Merge pull request #1 from awslabs/develop

merge from awslabs/develop

Author: praneetap

tests/translator/input/error_invalid_document_empty_semantic_version.yaml

@@ -0,0 +1,7 @@
+Resources:
+    helloworld:
+      Type: AWS::Serverless::Application
+      Properties:
+        Location:
+          ApplicationId: arn:aws:serverlessrepo:us-east-1:077246666028:applications/hello-world
+          SemanticVersion:

tests/translator/output/error_invalid_document_empty_semantic_version.json

@@ -0,0 +1,8 @@
+{
+  "errors": [
+    {
+      "errorMessage": "Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [helloworld] is invalid. Property 'SemanticVersion' cannot be blank."
+    }
+  ],
+  "errorMessage": "Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [helloworld] is invalid. Property 'SemanticVersion' cannot be blank."
+}

tests/translator/test_translator.py

@@ -440,7 +440,8 @@ def _generate_new_deployment_hash(self, logical_id, dict_to_hash, rest_api_to_sw
     'error_function_policy_template_invalid_value',
     'error_function_with_unknown_policy_template',
     'error_function_with_invalid_policy_statement',
-    'error_function_with_invalid_condition_name'
+    'error_function_with_invalid_condition_name',
+    'error_invalid_document_empty_semantic_version'
 ])
 @patch('boto3.session.Session.region_name', 'ap-southeast-1')
 @patch('samtranslator.plugins.application.serverless_app_plugin.ServerlessAppPlugin._sar_service_call', mock_sar_service_call)