Commit 8b153eb
GHA/windows: work around Git for Windows perf regression
Fix the significant perf regression for vcpkg jobs by switching to the
MSYS2 shell environment from Git for Windows. This env is already used
for old-mingw-w64 job that remained unaffected by this issue.
The issue began with the windows-runner update 20241015.1.0. It bumped
Git for Windows from Git 2.46.2.windows.1 to Git 2.47.0.windows.1. GfW
bumped its MSYS2 components, including `msys-2.0.dll`. That's Cygwin
code, which may have contributed to this. Pipes were involved and
`runtests.pl` relies on pipes heavily in parallel mode. (The issue was
not seen with parallel tests disabled, in retrospect.)
This is useful as a permanent solution too. It drop GfW as a dependency
and makes Windows jobs use one less shell/env flavour.
Long term it might help to use native Windows Perl to avoid the MSYS
layer completely, if there is a way to make that work.
Assortment of possibly related links:
https://cygwin.com/pipermail/cygwin/2024-August/256398.html
cygwin/cygwin@f78009c
cygwin/cygwin@7f3c225
actions/runner-images#10843
git-for-windows/git#5199
git-for-windows/msys2-runtime#75
git-for-windows/msys2-runtime@7913a41
git-for-windows/msys2-runtime@555afcb
cygwin/cygwin@1c5f4dc
Follow-up to c33174d curl#15364
Follow-up to 1e03059 curl#15356
Closes curl#153801 parent f8daf8f commit 8b153eb
1 file changed
+13
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
614 | 614 | | |
615 | 615 | | |
616 | 616 | | |
617 | | - | |
| 617 | + | |
618 | 618 | | |
619 | 619 | | |
620 | 620 | | |
| |||
737 | 737 | | |
738 | 738 | | |
739 | 739 | | |
| 740 | + | |
740 | 741 | | |
741 | 742 | | |
742 | 743 | | |
| |||
762 | 763 | | |
763 | 764 | | |
764 | 765 | | |
765 | | - | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
766 | 769 | | |
767 | 770 | | |
768 | 771 | | |
| |||
776 | 779 | | |
777 | 780 | | |
778 | 781 | | |
779 | | - | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
780 | 785 | | |
781 | 786 | | |
782 | 787 | | |
| |||
792 | 797 | | |
793 | 798 | | |
794 | 799 | | |
795 | | - | |
| 800 | + | |
796 | 801 | | |
797 | 802 | | |
798 | | - | |
799 | 803 | | |
800 | 804 | | |
801 | 805 | | |
802 | 806 | | |
803 | 807 | | |
804 | 808 | | |
| 809 | + | |
805 | 810 | | |
806 | 811 | | |
807 | 812 | | |
808 | 813 | | |
809 | | - | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
0 commit comments