[Fix] Sync stream connection #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicGBauer
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Sync Stream
A recent issue #11 (comment) showed that under certain conditions the sync stream network request would fail in web.
We currently use the fetch_client package to bind to the JS
fetchmethod. This supports streaming for request body and request responses. The streaming of request bodies requiresChromium 105+ based browsers and requires server to use HTTP/2 or HTTP/3. We only require streaming for request responses. This allows us to remove thestreamRequests: trueparam and maintain better compatibility.Dependency update
This PR also updates
sqlite_async.dartto the latest alpha version.Testing
This was tested in the Supabase todolist app. The sync stream connection was verified by having data sync down to the client in real time.
sync-requests.mov