[Alpha Fix] Disconnect and clear bug #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix lint issues in demos
* feat(attachments): add error handlers * fix: lint issue * chore: version bump * chore: pr reverts * Update packages/powersync_attachments_helper/lib/src/attachments_queue_table.dart Co-authored-by: stevensJourney <[email protected]> * Update demos/supabase-todolist/lib/attachments/queue.dart Co-authored-by: stevensJourney <[email protected]> * chore: improve demo * fix: image issue --------- Co-authored-by: DominicGBauer <[email protected]> Co-authored-by: stevensJourney <[email protected]>
rkistner
reviewed
Mar 5, 2024
rkistner
approved these changes
Mar 5, 2024
stevensJourney
force-pushed
the
alpha-fix-disconnect-and-clear
branch
from
1580f71 to
c7e646b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes multiple issues regarding disconnecting and clearing the database.
This also updates the
alpha-releasebranch with changes frommasterNative
For native platforms this fixes an issue where after calling
disconnectthe PowerSync client would fail to re-establish a valid streaming connection.This is fixed by updating
sqlite_asyncto0.7.0-alpha.2Web
For web this fixes an issue where if calling
disconnect(ordisconnectAndClear) multiple times, the abort controller was not cleared, which would attempt to abort twice - which throws an exception.If
disconnectwas called first, say from an authentication provider listener such as in here thendisconnectAndClearwas called thereafter, thedisconnectAndClearfunction would throw an exception before actually clearing the database.This PR properly aborts the web streaming sync connection and awaits for the abort process to complete.