Skip to content

chore(powersync): add max column check #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 23, 2024

Conversation

DominicGBauer
Copy link
Contributor

Description

Users currently only see an error for maxmium number of columns at runtime. This adds a check so that they would see it on Table creation.

Work Done

  • Added checks to Table and added some Table specific tests

@rkistner
Copy link
Contributor

The schema is currently not validated in applications at all - appears to be a regression from #92 / 1.4.0. Could you please add that back? See 4327b75 (also needs to be done for web).

This will also need a minor version bump at least.

@DominicGBauer
Copy link
Contributor Author

@rkistner this should now be ready to go

@DominicGBauer DominicGBauer merged commit 66ebe97 into main Aug 23, 2024
4 checks passed
@DominicGBauer DominicGBauer deleted the chore/add-max-column-check branch August 23, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants