Skip to content

race in lock_backup_exclusive #308

Closed
@gsmolk

Description

@gsmolk

https://github.com/postgrespro/pg_probackup/blob/master/src/catalog.c#L357

P1:

INFO: Running incremental restore into nonempty directory: "/data/postgresql"
WARNING: Backup QNSEGY is used without validation.
INFO: Restoring the database from backup at 2021-01-31 07:07:46+00
WARNING: Process 48710 is using backup QNSEGY, and is still running
WARNING: Waiting 30 seconds on lock for backup QNSEGY
WARNING: Process 48710 is using backup QNSEGY, and is still running
WARNING: Waiting 24 seconds on lock for backup QNSEGY
WARNING: Process 48710 is using backup QNSEGY, and is still running
WARNING: Waiting 18 seconds on lock for backup QNSEGY
ERROR: Could not remove old lock file "/backup/backups/node/QNSEGY/backup.pid": No such file or directory

P2:

INFO: Running incremental restore into nonempty directory: "/data/postgresql"
WARNING: Backup QNSEGY is used without validation.
INFO: Restoring the database from backup at 2021-01-31 07:07:46+00
WARNING: Lock file "/backup/backups/node/QNSEGY/backup.pid" is empty
INFO: Extracting the content of destination directory for incremental restore
INFO: Destination directory content extracted, time elapsed: 0
INFO: Removing redundant files in destination directory
INFO: Redundant files are removed, time elapsed: 0
...

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions