Rename New Project to New Folder from Template and update the associated new project wizard user experience #7893

softwarenerd · 2025-05-30T01:25:28Z

Description

This PR addresses #7559 by renaming New Project to New Folder from Template and updating the associated new project wizard user experience.

As part of this work:

New Project Wizard has been renamed to New Project Flow.
Project Type has been renamed to Folder Template.

When New Project from Template is invoked, there are now four folder templates:

Python Project
R Project
Jupyter Notebook
Empty Project (creates an empty project with no associated runtime or runtime environment)

Python Project

Here are screen shots of the New Folder from Template user experience for a new Python Project:

User selects Python Project folder template:

User selects folder name and location:

User configures the project, and then presses Create:

User selects where to open their newly-created folder:

Empty Project

Here are screen shots of the New Folder from Template user experience for a new Empty Project:

User selects Empty Project folder template:

User selects folder name and location, and then presses Create:

User selects where to open their newly-created folder:

Release Notes

New Features

N/A

Bug Fixes

New Project... could be New Folder Wizard... #7559 Rename New Project to New Folder and update the associated new project wizard user experience.

QA Notes

Tests:
@:new-project-wizard
@:welcome

github-actions · 2025-05-30T01:25:47Z

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:new-project-wizard @:welcome

^readme ^{valid tags}

DavisVaughan

I think this is a pretty big step in the right direction, and simplifies the language a lot!

Main comment is about the behavior of New Folder..., see below, but otherwise looks great

src/vs/workbench/browser/actions/positronActions.ts

src/vs/workbench/browser/positronNewProjectWizard/chooseNewProjectWindowModalDialog.tsx

src/vs/workbench/browser/positronNewProjectWizard/components/steps/projectTypeStep.tsx

src/vs/workbench/browser/positronNewProjectWizard/components/steps/rConfigurationStep.tsx

jonvanausdeln · 2025-05-30T16:40:10Z

Did this change the Welcome Page as well? We do have a couple of Welcome screen tests that may need to be updated.

https://github.com/posit-dev/positron/blob/bd3eba42d916aea13a87f6b7681532a63e33bb40/test/e2e/tests/welcome/welcome.test.ts

I can help if needed!

juliasilge

This is a HUGE improvement in terms of clarity and consistency, and I'm happy for this version of the FLOW 😄 to be what we launch with.

softwarenerd · 2025-06-04T20:29:03Z

Did this change the Welcome Page as well? We do have a couple of Welcome screen tests that may need to be updated.

https://github.com/posit-dev/positron/blob/bd3eba42d916aea13a87f6b7681532a63e33bb40/test/e2e/tests/welcome/welcome.test.ts

I can help if needed!

I have made the necessary adjustments.

Copilot

Pull Request Overview

This PR renames “New Project” to “New Folder from Template” and updates the associated wizard experience by renaming components, dialogs, CSS classes, actions, and related localizations.

Updated component and CSS names from “wizard” to “flow” to align with the new terminology.
Refactored actions and dialogs for creating a new folder from a template, including updates in localization and test cases.
Removed the deprecated newFolderModalDialog file to streamline the new folder workflow.

Reviewed Changes

Copilot reviewed 81 out of 81 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
folderTemplateGroup.tsx	Renaming and updating folder template picker logic.
flowSubStep.tsx, flowStep.tsx, flowFormattedText.tsx	Renaming components and CSS to reflect “flow” terminology.
chooseNewFolderWindowModalDialog.tsx	Updated dialog UI and localization for new folder creation.
positronActions.ts	Updated folder action triggers and registration.
Test and extension files	Adjusted naming in tests and commands to use folder terminology.

Comments suppressed due to low confidence (1)

src/vs/workbench/browser/positronNewFolderFlow/components/folderTemplateGroup.tsx:57

[nitpick] Consider using a unique identifier from folderTemplate as the key instead of the array index to improve stability during re-renders.

<FolderTemplatePicker key={index} ... />

src/vs/workbench/browser/positronNewFolderFlow/components/flowStep.tsx

juliasilge

Working great! 🚀

As a follow up, we might want to update the tag for tests from new-project-wizard to new-folder-flow cc @midleman

src/vs/workbench/browser/actions/positronActions.ts

dhruvisompura · 2025-06-05T01:30:59Z

src/vs/workbench/browser/positronNewFolderFlow/components/steps/folderNameLocationStep.tsx

+	const [projectName, setProjectName] = useState(context.folderName);
 	const [parentFolder, setParentFolder] = useState(() => pathUriToLabel(context.parentFolder, labelService));
-	const [projectNameFeedback, setProjectNameFeedback] = useState(context.projectNameFeedback);
-	const [maxProjectPathLength, setMaxProjectPathLength] = useState(() => getMaxProjectPathLength(parentFolder.length));
+	const [projectNameFeedback, setProjectNameFeedback] = useState(context.folderNameFeedback);
+	const [maxProjectPathLength, setMaxProjectPathLength] = useState(() => getMaxFolderPathLength(parentFolder.length));


I think we can update these state props to refer to folder. I'll push up those changes since @softwarenerd is OOO.

dhruvisompura · 2025-06-05T01:32:41Z

src/vs/workbench/browser/positronNewFolderFlow/components/steps/folderTemplateStep.tsx

+			context.folderTemplate !== selectedProjectType ||
+			context.folderName === ''
+		) {
+			const defaultProjectName = getDefaultFolderName(selectedProjectType);


A few updates to variables are needed here as well! I'll get those pushed up.

dhruvisompura · 2025-06-05T01:43:38Z

src/vs/workbench/browser/positronNewFolderFlow/components/steps/folderTemplateStep.tsx

+			<FolderTemplateGroup
+				describedBy='folder-template-selection-step-description'
+				labelledBy='folder-template-selection-step-title'
+				name='projectType'


We can update the name field for this input form as well. I didn't see any tests that were referencing this but I'll rerun all the e2e tests to make sure it doesn't break anything

dhruvisompura · 2025-06-05T01:47:15Z

src/vs/workbench/browser/positronNewFolderFlow/components/steps/rConfigurationStep.tsx

 					"Create"
 				))(),
 				disable: !selectedInterpreter
 			}}
 			title={(() => localize(
 				'rConfigurationStep.title',
-				"Set up project configuration"
+				"Project Configuration"


I'm guessing we are using the term project here on purpose for the R configuration step.

dhruvisompura · 2025-06-05T01:52:22Z

src/vs/workbench/contrib/positronNewProject/browser/positronNewProject.contribution.ts

We'll want to rename this file. I'm not sure what we want to call this - can be handled in a follow up.

dhruvisompura · 2025-06-05T01:55:04Z

src/vs/workbench/services/positronNewFolder/common/positronNewFolderEnablement.ts

Can we delete this file? It looks like its an unused feature flag.

softwarenerd requested review from dhruvisompura, juliasilge, DavisVaughan, sharon-wang and Copilot May 30, 2025 01:25

This comment was marked as outdated.

Sign in to view

DavisVaughan previously approved these changes May 30, 2025

View reviewed changes

softwarenerd requested a review from jthomasmock May 30, 2025 17:31

softwarenerd dismissed DavisVaughan’s stale review via 1593fda May 30, 2025 17:50

softwarenerd added 4 commits May 30, 2025 12:34

Rename New Project to New Folder

e9d5878

Add period back in

9fc8553

Update e2e test

1a602ef

Update welcome e2e tests

d042327

softwarenerd force-pushed the ui/new-folder-updates branch from 1593fda to d042327 Compare May 30, 2025 19:34

Rename New Project to New Folder from Template

9497cbf

juliasilge previously approved these changes Jun 3, 2025

View reviewed changes

Update to finalize implementation of New Folder Flow

dd9735a

softwarenerd dismissed juliasilge’s stale review via dd9735a June 4, 2025 18:45

softwarenerd changed the title ~~Rename New Project to New Folder and update the associated new project wizard user experience~~ Rename New Project to New Folder from Template and update the associated new project wizard user experience Jun 4, 2025

softwarenerd requested review from Copilot, DavisVaughan and juliasilge June 4, 2025 20:29

Copilot AI reviewed Jun 4, 2025

View reviewed changes

src/vs/workbench/browser/positronNewFolderFlow/components/flowStep.tsx Show resolved Hide resolved

juliasilge previously approved these changes Jun 4, 2025

View reviewed changes

dhruvisompura reviewed Jun 5, 2025

View reviewed changes

dhruvisompura added 2 commits June 4, 2025 19:08

Fix typo

fb05f4e

Remove unused feature flag

3d920d4

Update variables referencing project to folder

5f925a9

dhruvisompura dismissed juliasilge’s stale review via 5f925a9 June 5, 2025 02:09

sharon-wang mentioned this pull request Jun 5, 2025

Disable new folder from template when workspace is not trusted #7984

Open

Rename New Project to New Folder from Template and update the associated new project wizard user experience #7893

Are you sure you want to change the base?

Rename New Project to New Folder from Template and update the associated new project wizard user experience #7893

Uh oh!

Conversation

softwarenerd commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Python Project

Empty Project

Release Notes

New Features

Bug Fixes

QA Notes

Uh oh!

github-actions bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

DavisVaughan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonvanausdeln commented May 30, 2025

Uh oh!

juliasilge left a comment

Choose a reason for hiding this comment

Uh oh!

softwarenerd commented Jun 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

juliasilge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dhruvisompura Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

dhruvisompura Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

dhruvisompura Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

dhruvisompura Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

dhruvisompura Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

dhruvisompura Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

softwarenerd commented May 30, 2025 •

edited

Loading

github-actions bot commented May 30, 2025 •

edited

Loading