Skip serializing our internal language kernel terminal processes on shutdown #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hutdown When we quit Positron, we tear down any language runtime kernel processes (which are now managed by the terminal service host). These internal terminal processes should not be serialized/replayed on restarting Positron. This change attempts to detect those internal positron kernel terminal processes without changing the terminal service API. Issue: #213
|
Also added Pty Host attachment to our default debug launch profile for Positron. |
petetronic
commented
Feb 28, 2023
| @@ -409,7 +409,7 @@ export class JupyterKernel extends EventEmitter implements vscode.Disposable { | |||
| const command = args.join(' '); | |||
|
|
|||
| // Create environment. | |||
| const env = {}; | |||
| const env = { POSITRON_LANGUAGE: this._spec.language }; | |||
There was a problem hiding this comment.
Open to any suggestions on what a useful env var might be, for now it's just a flag.
There was a problem hiding this comment.
Maybe POSITRON_VERSION, since there's a 95% chance any code (other than ours) that wants to check this value already knows what the language is. But it's all speculative at this point, so this works too!
jmcphers
approved these changes
Mar 1, 2023
| @@ -409,7 +409,7 @@ export class JupyterKernel extends EventEmitter implements vscode.Disposable { | |||
| const command = args.join(' '); | |||
|
|
|||
| // Create environment. | |||
| const env = {}; | |||
| const env = { POSITRON_LANGUAGE: this._spec.language }; | |||
There was a problem hiding this comment.
Maybe POSITRON_VERSION, since there's a 95% chance any code (other than ours) that wants to check this value already knows what the language is. But it's all speculative at this point, so this works too!
wesm
pushed a commit
that referenced
this pull request
Mar 28, 2024
…python snippets Merge pull request #217 from posit-dev/feature/1437 Add initial placeholder for python snippets -------------------- Commit message for posit-dev/positron-python@a2971a6: Add initial placeholder for python snippets Establishes a mechanism to address #1437 Authored-by: Pete Farland <[email protected]> Signed-off-by: Pete Farland <[email protected]>
wesm
pushed a commit
that referenced
this pull request
Mar 28, 2024
…python snippets Merge pull request #217 from posit-dev/feature/1437 Add initial placeholder for python snippets -------------------- Commit message for posit-dev/positron-python@a2971a6: Add initial placeholder for python snippets Establishes a mechanism to address #1437 Authored-by: Pete Farland <[email protected]> Signed-off-by: Pete Farland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we quit Positron, we tear down any language runtime kernel processes (which are now managed by the terminal service host).
These internal terminal processes should not be serialized/replayed on restarting Positron.
This change attempts to detect those internal positron kernel terminal processes without changing the terminal service API.
Issue: #213