Update rpp to work with latest React, R3F and PP, add GH actions #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2023 19:09
|
I copy pasted code from this PR to cdsbx, seems to work fine: https://codesandbox.io/s/ancient-sky-ldkxwk?file=/src/App.tsx |
talentlessguy
changed the title
added 4 commits
April 26, 2023 12:23
| "baseUrl": ".", | ||
| "declaration": true, | ||
| "outDir": "dist", | ||
| "skipLibCheck": true, |
There was a problem hiding this comment.
What is this for? I'd also try to enable strict if possible.
There was a problem hiding this comment.
on pnpm types resolution doesn't work properly without this prop
added 8 commits
April 28, 2023 14:44
added 9 commits
April 28, 2023 14:58
… into react-18-last-pp-last-three
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useThreehook usageexportsfieldI haven't tested yet if all the effects work, in progress