Add code and test assurance testing #95
Conversation
bpostlethwaite
force-pushed
the
AddCodeAndTestAssuranceTesting
branch
2 times, most recently
from
83e7b84 to
0390263
Compare
src/__tests__/syntax-test.js
Outdated
| import glob from 'glob'; | ||
|
|
||
| const BLACK_LIST = ['fdescribe', 'fit', 'xdescribe', 'xit']; | ||
| const REGEXS = BLACK_LIST.map(token => new RegExp(`.*${token}\\(.*`)); |
There was a problem hiding this comment.
might need to be a bit stricter, in case someone uses the word "exit", or "fitting" or something... plotly.js uses falafel to make sure we're just matching identifiers:
https://github.com/plotly/plotly.js/blob/master/tasks/test_syntax.js#L28
There was a problem hiding this comment.
Yeh I tried that but had issues running it inside Jest. I think anchoring the token to the beginning of the line preceded by 0-n spaces should suffice. That works for streambed and this codebase is much smaller.
There was a problem hiding this comment.
Ah I see... doesn't like jsx perhaps... so maybe .*\W${token}\W.*?
There was a problem hiding this comment.
incidentally if it is jsx that's the problem, there is a solution for it in falafel https://github.com/substack/node-falafel/blob/master/readme.markdown#custom-parser
bpostlethwaite
force-pushed
the
AddCodeAndTestAssuranceTesting
branch
from
0390263 to
88c08c6
Compare
|
💃 |
@alexcjohnson okay final piece before the merge to master. This PR adds a Jasmine test skip blacklist and both syntactic and logical code checks in CI using
prettierandeslint.