frames support + slider styling controls #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
commented
Mar 13, 2018
| @@ -30,6 +30,7 @@ class EditorControls extends Component { | |||
| dataSourceValueRenderer: this.props.dataSourceValueRenderer, | |||
| dataSourceOptionRenderer: this.props.dataSourceOptionRenderer, | |||
| dictionaries: this.props.dictionaries || {}, | |||
| frames: gd._transitionData ? gd._transitionData._frames : [], | |||
There was a problem hiding this comment.
although here I've noticed it's a little odd that my gd doesn't always get _transitionData, sometimes it's undefined..
it's a little odd because it seems to me like this key is always on gd, even if there's no frames...
like here:https://codepen.io/veraz/pen/zRRONV
VeraZab
force-pushed
the
animations
branch
3 times, most recently
from
d9aca42 to
a8728a3
Compare
|
💃 for what we've got so far! would be nice to get some of those naming bits sorted out too but that could go into a later pass |
|
Also we should add a panel-link-visibility item to #290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nicolaskruchten ready for review
partially closes #391