Grouped Trace tabs #312
Grouped Trace tabs #312
Conversation
|
Oh I should mention that trace type names in a group context are not localized (or even properly capitalized!) yet but that will come once #311 is merged and I'll be able to leverage those localized constants from somewhere. |
|
I've added an item to #290 to capture this. |
src/components/containers/Panel.js
Outdated
| @@ -106,7 +108,7 @@ class Panel extends Component { | |||
| ); | |||
|
|
|||
| return ( | |||
| <div className={bem('panel')}> | |||
| <div className={`panel${tabs ? ' panel--with-tabs' : ''}`}> | |||
There was a problem hiding this comment.
yeah, I think we're not really using that bem stuff, we should probably remove it at some point..
There was a problem hiding this comment.
This was added by @aulneau so we should get his input... we should either do one big pass where we remove it or add it everywhere in a single PR but agreed that we should standardize!
There was a problem hiding this comment.
no : ) this was added before aulneau, we've just all been adding to it, but yeah @aulneau what do you think about that bem utility, useful?
There was a problem hiding this comment.
Oh, did you mean the bem() function or the actual BEM pattern?
And yes, the particular edit you're commenting on came from Thomas ;)
There was a problem hiding this comment.
actually come to think of it I was going to refactor it a bit, good that you chose this one to comment on!
There was a problem hiding this comment.
in the same family of functions as things like bem() I like https://github.com/JedWatson/classnames FWIW...
There was a problem hiding this comment.
I meant the bem function, which was introduced before @aulneau started contributing to this project : )
|
This is clean! I'm just going to check out this branch and test it out, but 💃 |
This PR replaces #160. Multi-value UX similar to Axes panel yet to come, in another PR :)