Fix for axes types not updating with new data types fixes #103 #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpostlethwaite
force-pushed
the
TemporaryFixForAxesTypeClearing
branch
from
48d6be1 to
ca5e2dd
Compare
bpostlethwaite
changed the title
bpostlethwaite
force-pushed
the
TemporaryFixForAxesTypeClearing
branch
from
ca5e2dd to
6d180b8
Compare
This is temporary fix until plotly/react-plotly.js#2 has been released
bpostlethwaite
force-pushed
the
TemporaryFixForAxesTypeClearing
branch
from
6d180b8 to
3f5b4c4
Compare
alexcjohnson
approved these changes
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #103
@alexcjohnson Ok the fix was pretty easy after a nights sleep. I winnowed away unnecessary code in the cleanAxisTypes function. It turns out if you ignore 3D (scenes) you don't need to make any calls to
_modules. That means we are working with pure functions which can be used statically. That also means this fix won't apply to 3D but that is a trade off I am willing to make since plotly/react-plotly.js#2 will solve the issue for all cases.