Skip to content

Commit 453d1b6

Browse files
Merge pull request #380 from plotly/fix_issues_and_awesome_improvements_in_meshc_functionality
fix issues and awesome improvements in meshc functionality
2 parents 8af0338 + b001a62 commit 453d1b6

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

plotly/plotlyfig_aux/core/updateData.m

+2
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535
updateMesh(obj, dataIndex);
3636
elseif strcmpi(obj.PlotOptions.TreatAs, 'surfc')
3737
updateSurfc(obj, dataIndex);
38+
elseif strcmpi(obj.PlotOptions.TreatAs, 'meshc')
39+
updateSurfc(obj, dataIndex);
3840

3941
% this one will be revomed
4042
elseif strcmpi(obj.PlotOptions.TreatAs, 'streamtube')

plotly/plotlyfig_aux/handlegraphics/updateSurfc.m

+9-7
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,14 @@ function updateSurfOnly(obj, surfaceIndex)
232232
obj.data{surfaceIndex}.contours.x.start = xData(1);
233233
obj.data{surfaceIndex}.contours.x.end = xData(end);
234234
obj.data{surfaceIndex}.contours.x.size = mean(diff(xData));
235+
obj.data{surfaceIndex}.contours.x.show = true;
235236

236237
% y-direction
237238
yData = yData(:, 1);
238239
obj.data{surfaceIndex}.contours.y.start = yData(1);
239240
obj.data{surfaceIndex}.contours.y.end = yData(end);
240241
obj.data{surfaceIndex}.contours.y.size = mean(diff(yData));;
242+
obj.data{surfaceIndex}.contours.y.show = true;
241243

242244
%-------------------------------------------------------------------------%
243245

@@ -273,6 +275,9 @@ function updateSurfOnly(obj, surfaceIndex)
273275
obj.data{surfaceIndex}.contours.x.colorscale = cDataContour;
274276
obj.data{surfaceIndex}.contours.y.colorscale = cDataContour;
275277

278+
obj.data{surfaceIndex}.contours.x.show = false;
279+
obj.data{surfaceIndex}.contours.y.show = false;
280+
276281
elseif strcmpi(meshData.EdgeColor, 'flat')
277282
cData = meshData.CData;
278283

@@ -291,21 +296,20 @@ function updateSurfOnly(obj, surfaceIndex)
291296
obj.data{surfaceIndex}.line.cmin = 0;
292297
obj.data{surfaceIndex}.line.cmax = 255;
293298
obj.data{contourIndex}.line.colorscale = edgeColorScale;
294-
obj.data{surfaceIndex}.contours.x.colorscale = edgeColorScale;
295-
obj.data{surfaceIndex}.contours.y.colorscale = edgeColorScale;
296299
else
297300
obj.data{contourIndex}.line.cmin = axisData.CLim(1);
298301
obj.data{contourIndex}.line.cmax = axisData.CLim(2);
299302
obj.data{contourIndex}.line.colorscale = colorScale;
300-
obj.data{surfaceIndex}.contours.x.colorscale = colorScale;
301-
obj.data{surfaceIndex}.contours.y.colorscale = colorScale;
302303
end
303304

304305
cDataContourDir1 = [cData; NaN(1, size(cData, 2))];
305306
cDataContourDir2 = cDataContourDir1(1:end-1,:)';
306307
cDataContourDir2 = [cDataContourDir2; NaN(1, size(cDataContourDir2, 2))];
307308
cDataContour = [cDataContourDir1(:); cDataContourDir2(:)];
308309

310+
obj.data{surfaceIndex}.contours.x.show = false;
311+
obj.data{surfaceIndex}.contours.y.show = false;
312+
309313
elseif strcmpi(meshData.EdgeColor, 'none')
310314
cDataContour = 'rgba(0,0,0,0)';
311315

@@ -412,12 +416,10 @@ function updateSurfOnly(obj, surfaceIndex)
412416
%-------------------------------------------------------------------------%
413417

414418
%-line style-%
415-
obj.data{contourIndex}.line.width = 1.5*meshData.LineWidth;
419+
obj.data{contourIndex}.line.width = 3*meshData.LineWidth;
416420

417421
if strcmpi(meshData.LineStyle, '-')
418422
obj.data{contourIndex}.line.dash = 'solid';
419-
obj.data{surfaceIndex}.contours.x.show = true;
420-
obj.data{surfaceIndex}.contours.y.show = true;
421423
else
422424
obj.data{contourIndex}.line.dash = 'dot';
423425
obj.data{surfaceIndex}.contours.x.show = false;

0 commit comments

Comments
 (0)