-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Plus 2 colorscale #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plus 2 colorscale #477
Conversation
…tered some color type-swapping functions
Just doing it in this PR works for me. |
… docs//reworked some helper functions to accept color values in addition to lists of color values
@theengineear @jackparmer @choldgraf So Scatterplotmatrix has been completely reworked to allow for divergent and categorical colormaps. In particular, you can give it a list of an arbitrary number of colors (with mixing and matching color types) and it cat make a divergent colormap between these colors. If you want to assign specific index values to a specific color, just input colormap (new param) as a dictionary and assign a color to each value. The tests should pass and some pictures are posted below. I want to get this thing up and merged as soon as we can. Some of the trisurf code is old and has already been updated in master iirc. |
yep, the trisurf code is already updated and there's a PR just needs some tiny fixes and will probably be ready to go today. I am generally +1 to colormap improvements, as I've found it to be a little clunky. I basically just use helpers that take |
Cool, lmk when you've had time to peek through mine and then it'll be ready Sent from my phone, apologies for the curtness and type-os
|
Was about to check it out. |
@theengineear @jackparmer
This pull request is for updating all my figurefactories (trisurf, scatterplotmatrix, violin, gantt eventually) so that they support more than 2 color lists as inputs.
I've only dealt with trisurf here, changing the framework for how colormap is validated.
Should I make separate branches for each of the figurefactories, or just work in this PR?