Skip to content

Plus 2 colorscale #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2016
Merged

Plus 2 colorscale #477

merged 6 commits into from
May 27, 2016

Conversation

Kully
Copy link
Contributor

@Kully Kully commented May 24, 2016

@theengineear @jackparmer

This pull request is for updating all my figurefactories (trisurf, scatterplotmatrix, violin, gantt eventually) so that they support more than 2 color lists as inputs.

I've only dealt with trisurf here, changing the framework for how colormap is validated.

Should I make separate branches for each of the figurefactories, or just work in this PR?

@theengineear
Copy link
Contributor

Should I make separate branches for each of the figurefactories, or just work in this PR?

Just doing it in this PR works for me.

Kully added 2 commits May 25, 2016 12:59
… docs//reworked some helper functions to accept color values in addition to lists of color values
@Kully
Copy link
Contributor Author

Kully commented May 27, 2016

@theengineear @jackparmer @choldgraf

So Scatterplotmatrix has been completely reworked to allow for divergent and categorical colormaps. In particular, you can give it a list of an arbitrary number of colors (with mixing and matching color types) and it cat make a divergent colormap between these colors.

If you want to assign specific index values to a specific color, just input colormap (new param) as a dictionary and assign a color to each value.

The tests should pass and some pictures are posted below.

I want to get this thing up and merged as soon as we can. Some of the trisurf code is old and has already been updated in master iirc.

scatterplot matrix - colormap dictionary

scatterplot matrix - intervals

@Kully
Copy link
Contributor Author

Kully commented May 27, 2016

divergent scale

@choldgraf
Copy link
Contributor

yep, the trisurf code is already updated and there's a PR just needs some tiny fixes and will probably be ready to go today.

I am generally +1 to colormap improvements, as I've found it to be a little clunky. I basically just use helpers that take matplotlib colormaps and return rgb strings a ton (maybe that already exists in plotly though). There's also a big chunk of create_trisurf that is just choosing what colormap to use, and my guess is that could be wrapped up in a hidden function and applied to lots of other things in FF too.

@Kully Kully merged commit 5c11b56 into master May 27, 2016
@choldgraf
Copy link
Contributor

Cool, lmk when you've had time to peek through mine and then it'll be ready
too

Sent from my phone, apologies for the curtness and type-os
On May 27, 2016 8:03 AM, "Adam Kulidjian" [email protected] wrote:

Merged #477 #477.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#477 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABwSHX_3Bq__vHrNgM2tBMSDAOCOf24zks5qFwe0gaJpZM4Il2zB
.

@Kully
Copy link
Contributor Author

Kully commented May 27, 2016

Cool, lmk when you've had time to peek through mine and then it'll be ready
too

Was about to check it out.

@Kully Kully deleted the Plus_2_Colorscale branch May 27, 2016 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants