Skip to content

Single commit of child window fixes #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nielsenb-jf
Copy link
Contributor

This pull request fixes the issues noted in issue 702. Essentially, if Plotly was provided an element in a different window or tab, the plot would not be styled correctly and interactivity (hovers, drag zoom, etc.) would not work.

It is squished to one commit due to issues caused by multiple merges during development see this previous PR.

The following are the big changes to fix this issue:

  • Graph divs now keep a reference to their 'parent' document in the `_document' property.
  • Styles are now injected to the parent document on the first call to Plotly.plot.
  • Anything that draws over a document for interactivity purposes (eg. dragcovers), now uses the _document reference to ensure it is drawn in the correct document.
  • Notifiers now require a graph div as the first argument so that notifications are rendered in the correct place

@etpinard
Copy link
Contributor

Hmm. That commit message was meant to be temporary. Can you git commit --amend it? Thanks.

@nielsenb-jf
Copy link
Contributor Author

Try this PR.

@etpinard
Copy link
Contributor

In the future, you can git push -f instead of opening new PRs every time.

@etpinard etpinard deleted the squash-child-window branch July 29, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants