Skip to content

fix error bar trace ordering [fixes #338] #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 21, 2016
Merged

fix error bar trace ordering [fixes #338] #343

merged 8 commits into from
Mar 21, 2016

Conversation

etpinard
Copy link
Contributor

@mdtusz

In brief

This PR:

  • removes <g class="errorlayer"> from the cartesian plot framework.
  • error bars nodes are now consider part of the <g class="trace">
  • error bars nodes are placed below all other point nodes in scatter traces and above all other point nodes in bar/histogram traces.
  • updates an old (wrong) image baseline and adds another image test

Important considerations

  • The ErrorBars component is now required in the Scatter and Bar plot and style steps, instead of being called from the module-loop in Cartesian.plot.
  • I chose to keep the ErrorBars.calc call in the main Plotly.plot routine. The error bar calc step needs to be in the positionAndAutorange block to properly update the axes ranges. Perhaps, we could make a setPositions in Scatter and have it call ErrorBars.calc ?

@mdtusz
Copy link
Contributor

mdtusz commented Mar 21, 2016

Clean and simple. I don't have anything to critique on this one!

💃

etpinard added a commit that referenced this pull request Mar 21, 2016
fix error bar trace ordering [fixes #338]
@etpinard etpinard merged commit e891bac into master Mar 21, 2016
@etpinard etpinard deleted the error-order branch March 21, 2016 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants