Fix for issue 1976 - remove webgl warnings for empty lines when using gl-line3d #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Oct 29, 2018
package.json
Outdated
| @@ -74,7 +74,7 @@ | |||
| "gl-contour2d": "^1.1.4", | |||
| "gl-error3d": "^1.0.8", | |||
| "gl-heatmap2d": "^1.0.4", | |||
| "gl-line3d": "^1.1.4", | |||
| "gl-line3d": "git://github.com/gl-vis/gl-line3d.git#860955328a385e0bdbd6d8b1d72b0a0ca433e6c7", | |||
|
Test added in afac92b Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1976 and cases where the line trace has segments less than one. This help avoid
throwing WebGL rendering warnings. Similar to PR #3171 (related to empty texts on gl-scatter3d) the conditions for checking array inputs are improved within the gl-line3d module.
@etpinard
@alexcjohnson