prevent our loggers from throwing their own errors in a few more cases #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
Oct 22, 2018
| try { | ||
| // `this` should always be console, since here we're always | ||
| // applying a method of the console object. | ||
| f.apply(console, args); |
There was a problem hiding this comment.
In current browsers this works anyway, but console is really the right this here and some old browsers (Chrome 51 and presumably before) need it to be correct. See eg https://github.com/plotly/phoenix-integration/issues/223#issuecomment-431863801
|
Looks good to me! Maybe wait for the CI tests to run and then 💃 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @antoinerg - a sort of followup to #3114