Bar axis autorange fix #2050
Merged
Bar axis autorange fix #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 💃 Thanks 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2049 - cleaner handling of base and zero for bar axis autorange.
We don't need to include 0 explicitly in the autorange for bars (unless we're normalizing), nor should we be including the bar base unless that was explicitly specified.
Most of the time these extras were just redundant, but for bars on date axes (which is not really a kosher use of bars but we don't forbid it) the zero (1970) is arbitrary and it's confusing and useless if this gets included in the autorange.
cc @etpinard